Skip to content

docs: Updated quickstart docs to import FeatureService#2987

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
franciscojavierarceo:readme-patch
Aug 1, 2022
Merged

docs: Updated quickstart docs to import FeatureService#2987
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
franciscojavierarceo:readme-patch

Conversation

@franciscojavierarceo
Copy link
Member

@franciscojavierarceo franciscojavierarceo commented Jul 31, 2022

The quickstart is missing an import.

What this PR does / why we need it:

Just updates the quickstart notebook.

@franciscojavierarceo franciscojavierarceo mentioned this pull request Jul 31, 2022
Closed
@franciscojavierarceo franciscojavierarceo changed the title docs: updated quickstart docs to import FeatureService docs: Updated quickstart docs to import FeatureService Jul 31, 2022
felixwang9817
felixwang9817 approved these changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@franciscojavierarceo thanks for the fix!

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, franciscojavierarceo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022 •
edited
Loading

Codecov Report

Merging #2987 (13219d5) into master (2ef71fc) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2987      +/-   ##
==========================================
- Coverage   77.89%   77.85%   -0.05%     
==========================================
  Files         193      193              
  Lines       16589    16589              
==========================================
- Hits        12922    12915       -7     
- Misses       3667     3674       +7
Flag Coverage Δ
integrationtests 68.03% <ø> (-0.16%) ⬇️
unittests 58.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/basic_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...east/infra/materialization/lambda/lambda_engine.py 93.75% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef71fc...13219d5. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit 5358f0d into feast-dev:master Aug 1, 2022
adchia pushed a commit that referenced this pull request Aug 1, 2022
@franciscojavierarceo @adchia
docs: Updated quickstart docs to import FeatureService (#2987)
a39819c 
docs: updated quickstart docs to import FeatureService

Signed-off-by: Francisco Javier Arceo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@felixwang9817 felixwang9817

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@franciscojavierarceo @feast-ci-bot @codecov-commenter @felixwang9817