Skip to content

chore: Update offline and online store docs#3048

Merged
feast-ci-bot merged 4 commits intofeast-dev:masterfrom
kevjumba:fix_docs
Aug 12, 2022
Merged

chore: Update offline and online store docs#3048
feast-ci-bot merged 4 commits intofeast-dev:masterfrom
kevjumba:fix_docs

Conversation

@kevjumba
Copy link
Collaborator

@kevjumba kevjumba commented Aug 9, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022 •
edited
Loading

Codecov Report

Merging #3048 (bb86857) into master (0ed1a63) will increase coverage by 8.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3048      +/-   ##
==========================================
+ Coverage   67.44%   75.93%   +8.48%     
==========================================
  Files         169      203      +34     
  Lines       14936    16839    +1903     
==========================================
+ Hits        10074    12786    +2712     
+ Misses       4862     4053     -809
Flag Coverage Δ
integrationtests 67.29% <ø> (-0.15%) ⬇️
unittests 58.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../feature_repos/universal/online_store/cassandra.py 42.85% <0.00%> (ø)
...s/contrib/trino_offline_store/connectors/upload.py 8.97% <0.00%> (ø)
...tores/contrib/trino_offline_store/trino_queries.py 15.05% <0.00%> (ø)
...b/cassandra_online_store/cassandra_online_store.py 2.63% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
...ores/contrib/trino_offline_store/trino_type_map.py 6.66% <0.00%> (ø)
...s/contrib/postgres_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
...s/contrib/trino_offline_store/tests/data_source.py 17.64% <0.00%> (ø)
...k/python/feast/infra/materialization/lambda/app.py 26.66% <0.00%> (ø)
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <0.00%> (ø)
... and 98 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

adchia
adchia reviewed Aug 9, 2022
View reviewed changes
docs/how-to-guides/customizing-feast/adding-support-for-a-new-online-store.md Outdated
Copy link
Collaborator

@adchia adchia Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is actually not a good example since the pytest plugin uses the offline store. Maybe sync and copy the cassandra one?

Copy link
Collaborator Author

@kevjumba kevjumba Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@adchia adchia self-assigned this Aug 9, 2022
adchia
adchia reviewed Aug 12, 2022
View reviewed changes
Makefile Outdated
Copy link
Collaborator

@adchia adchia Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this right? seems like it should be using the cassandra plugins?

Copy link
Collaborator Author

@kevjumba kevjumba Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator Author

@kevjumba kevjumba Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works with the module around the online stores but I can also just plugin the actual file

@kevjumba
Fix
c77984c 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
7ed3676 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
d5ee116 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
bb86857 
Signed-off-by: Kevin Zhang <[email protected]>
adchia
adchia approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Aug 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 66d2c76 into feast-dev:master Aug 12, 2022
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Aug 13, 2022
@kevjumba @franciscojavierarceo
chore: Update offline and online store docs (feast-dev#3048)
818d61d 
* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

Signed-off-by: Kevin Zhang <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
adchia pushed a commit that referenced this pull request Aug 15, 2022
@kevjumba @adchia
chore: Update offline and online store docs (#3048)
ac782bf 
* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

Signed-off-by: Kevin Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

Assignees

@adchia adchia

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevjumba @codecov-commenter @feast-ci-bot @adchia