Skip to content

docs: Codebase structure#3050

Merged
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
felixwang9817:codebase_structure_docs
Aug 12, 2022
Merged

docs: Codebase structure#3050
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
felixwang9817:codebase_structure_docs

Conversation

@felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Aug 9, 2022

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@felixwang9817 felixwang9817 force-pushed the codebase_structure_docs branch 2 times, most recently from 082778d to 31b1d47 Compare August 9, 2022 21:47
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022 •
edited
Loading

Codecov Report

Merging #3050 (34f91cc) into master (0ed1a63) will increase coverage by 8.27%.
The diff coverage is n/a.

❗ Current head 34f91cc differs from pull request most recent head c2ab2a6. Consider uploading reports for the commit c2ab2a6 to get more accurate results

@@            Coverage Diff             @@
##           master    #3050      +/-   ##
==========================================
+ Coverage   67.44%   75.72%   +8.27%     
==========================================
  Files         169      203      +34     
  Lines       14936    16856    +1920     
==========================================
+ Hits        10074    12764    +2690     
+ Misses       4862     4092     -770
Flag Coverage Δ
integrationtests 67.24% <ø> (-0.20%) ⬇️
unittests 58.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...offline_stores/contrib/spark_repo_configuration.py 100.00% <0.00%> (ø)
.../contrib/athena_offline_store/tests/data_source.py 48.83% <0.00%> (ø)
...s/contrib/postgres_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <0.00%> (ø)
.../contrib/postgres_offline_store/postgres_source.py 50.66% <0.00%> (ø)
...ontrib/postgres_offline_store/tests/data_source.py 51.02% <0.00%> (ø)
...s/contrib/trino_offline_store/connectors/upload.py 8.97% <0.00%> (ø)
sdk/python/feast/transformation_server.py 40.47% <0.00%> (ø)
...line_stores/contrib/athena_offline_store/athena.py 38.12% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
... and 98 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixwang9817 felixwang9817 force-pushed the codebase_structure_docs branch from 31b1d47 to 2ffebcb Compare August 9, 2022 22:30
achals
achals reviewed Aug 9, 2022
View reviewed changes
docs/reference/codebase-structure.md Outdated
Copy link
Member

@achals achals Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, the regsitry interface (BaseRegistry) and the file based implementation (Regsitry) lives here. The SQL regisry is in infra/regsitry_stores (which is probably not the best name or place.

Copy link
Collaborator Author

@felixwang9817 felixwang9817 Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

docs/reference/codebase-structure.md Outdated
Copy link
Member

@achals achals Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And materialization engines

docs/reference/codebase-structure.md Outdated
Copy link
Member

@achals achals Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's a plan?

docs/reference/codebase-structure.md Outdated
Copy link
Member

@achals achals Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also registry stores.

adchia
adchia reviewed Aug 9, 2022
View reviewed changes
docs/reference/codebase-structure.md Outdated
Copy link
Collaborator

@adchia adchia Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one might be a bit excessive :P

Copy link
Collaborator Author

@felixwang9817 felixwang9817 Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad I tried

docs/reference/codebase-structure.md Outdated
Copy link
Collaborator

@adchia adchia Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plans is ambiguous. explain that?

docs/reference/codebase-structure.md Outdated
Copy link
Collaborator

@adchia adchia Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe call out that this is what is launched with feast serve?

docs/reference/codebase-structure.md Outdated
Copy link
Collaborator

@adchia adchia Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead: tree --dirsfirst -L 1 -C infra so directories show up first?

docs/reference/codebase-structure.md Outdated
Copy link
Collaborator

@adchia adchia Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map this to what users know about? aka this is what feature_store.yaml configuration maps to in memory

@felixwang9817 felixwang9817 force-pushed the codebase_structure_docs branch 3 times, most recently from 10b8f94 to 34f91cc Compare August 11, 2022 21:22
adchia
adchia approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@felixwang9817
Codebase structure docs
df26658 
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817
Address code review
c2ab2a6 
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817 felixwang9817 force-pushed the codebase_structure_docs branch from 34f91cc to c2ab2a6 Compare August 12, 2022 20:08
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 12, 2022
adchia
adchia approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Aug 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 492a90d into feast-dev:master Aug 12, 2022
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Aug 13, 2022
@felixwang9817 @franciscojavierarceo
docs: Codebase structure (feast-dev#3050)
2e0af31 
* Codebase structure docs

Signed-off-by: Felix Wang <[email protected]>

* Address code review

Signed-off-by: Felix Wang <[email protected]>

Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
adchia pushed a commit that referenced this pull request Aug 15, 2022
@felixwang9817 @adchia
docs: Codebase structure (#3050)
54c07d7 
* Codebase structure docs

Signed-off-by: Felix Wang <[email protected]>

* Address code review

Signed-off-by: Felix Wang <[email protected]>

Signed-off-by: Felix Wang <[email protected]>
adchia pushed a commit that referenced this pull request Aug 15, 2022
@felixwang9817 @adchia
docs: Codebase structure (#3050)
9d2e042 
* Codebase structure docs

Signed-off-by: Felix Wang <[email protected]>

* Address code review

Signed-off-by: Felix Wang <[email protected]>

Signed-off-by: Felix Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals left review comments

@adchia adchia adchia approved these changes

Assignees

@adchia adchia

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felixwang9817 @codecov-commenter @feast-ci-bot @achals @adchia