Skip to content

feat: Add workgroup to athena offline store config#3139

Merged
feast-ci-bot merged 6 commits intofeast-dev:masterfrom
derek1032:add-workgroup-to-athena-offline-store-config
Aug 25, 2022
Merged

feat: Add workgroup to athena offline store config#3139
feast-ci-bot merged 6 commits intofeast-dev:masterfrom
derek1032:add-workgroup-to-athena-offline-store-config

Conversation

@derek1032
Copy link
Contributor

@derek1032 derek1032 commented Aug 25, 2022

This PR is for allowing users to specify Athena workgroup in offline store config of the file feature_store.yaml. In addition, this PR also fixed feast module import error, so that athena universal tests can be successfully run.

Run two tests:

  1. unit tests (test-python): 135 passed, 471 warnings, 2 errors
  2. universal tests (test-python-universal-athena): 2 failed, 61 passed, 15 skipped, 5 warnings, 2 errors
For unit tests:
ERROR sdk/python/tests/integration/e2e/test_go_feature_server.py
ERROR sdk/python/tests/unit/infra/online_store/test_dynamodb_online_store.py

For universal tests:
FAILED sdk/python/tests/integration/offline_store/test_push_features_to_offline_store.py::test_push_features_and_r
ead[AWS:Athena:sqlite:python_fs:False:go_fs:False]
FAILED sdk/python/tests/integration/registration/test_universal_cli.py::test_nullable_online_store[test_nullable_o
nline_store1]

Fixes #3129

@derek1032 derek1032 changed the title Add workgroup to athena offline store config feat : Add workgroup to athena offline store config Aug 25, 2022
@derek1032 derek1032 changed the title feat : Add workgroup to athena offline store config feat: Add workgroup to athena offline store config Aug 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #3139 (aca2606) into master (9f78367) will decrease coverage by 9.05%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master    #3139      +/-   ##
==========================================
- Coverage   67.11%   58.06%   -9.06%     
==========================================
  Files         175      209      +34     
  Lines       15905    17487    +1582     
==========================================
- Hits        10675    10153     -522     
- Misses       5230     7334    +2104
Flag Coverage Δ
integrationtests ?
unittests 58.06% <16.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ores/contrib/athena_offline_store/athena_source.py 45.61% <ø> (ø)
.../contrib/athena_offline_store/tests/data_source.py 46.66% <0.00%> (ø)
sdk/python/feast/infra/utils/aws_utils.py 29.26% <0.00%> (-33.74%) ⬇️
...line_stores/contrib/athena_offline_store/athena.py 36.81% <100.00%> (ø)
...ffline_stores/contrib/athena_repo_configuration.py 100.00% <100.00%> (ø)
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) ⬇️
... and 168 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

felixwang9817
felixwang9817 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

achals
achals approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Aug 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, derek1032, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit a752211 into feast-dev:master Aug 25, 2022
felixwang9817 pushed a commit that referenced this pull request Sep 20, 2022
@feast-ci-bot
chore(release): release 0.25.0
769c318 
# [0.25.0](v0.24.0...v0.25.0) (2022-09-20)

### Bug Fixes

* Broken Feature Service Link ([#3227](#3227)) ([e117082](e117082))
* Feature-server image is missing mysql dependency for mysql registry ([#3223](#3223)) ([ae37b20](ae37b20))
* Fix handling of TTL in Go server ([#3232](#3232)) ([f020630](f020630))
* Fix materialization when running on Spark cluster. ([#3166](#3166)) ([175fd25](175fd25))
* Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([7c50ab5](7c50ab5))
* Fix release workflow ([#3144](#3144)) ([20a9dd9](20a9dd9))
* Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([de75971](de75971))
* Handle complex Spark data types in SparkSource ([#3154](#3154)) ([5ddb83b](5ddb83b))
* Local staging location provision ([#3195](#3195)) ([cdf0faf](cdf0faf))
* Remove bad snowflake offline store method ([#3204](#3204)) ([dfdd0ca](dfdd0ca))
* Remove opening file object when validating S3 parquet source ([#3217](#3217)) ([a906018](a906018))
* Snowflake config file search error ([#3193](#3193)) ([189afb9](189afb9))
* Update Snowflake Online docs ([#3206](#3206)) ([7bc1dff](7bc1dff))

### Features

* Add `to_remote_storage` functionality to `SparkOfflineStore` ([#3175](#3175)) ([2107ce2](2107ce2))
* Add ability to give boto extra args for registry config ([#3219](#3219)) ([fbc6a2c](fbc6a2c))
* Add health endpoint to py server ([#3202](#3202)) ([43222f2](43222f2))
* Add snowflake support for date & number with scale ([#3148](#3148)) ([50e8755](50e8755))
* Add tag kwarg to set Snowflake online store table path ([#3176](#3176)) ([39aeea3](39aeea3))
* Add workgroup to athena offline store config ([#3139](#3139)) ([a752211](a752211))
* Implement spark materialization engine ([#3184](#3184)) ([a59c33a](a59c33a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@achals achals

@felixwang9817 felixwang9817

Labels

approved lgtm ok-to-test size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow users to specify Athena workgroup in Athena offline store config

5 participants

@derek1032 @codecov-commenter @feast-ci-bot @achals @felixwang9817