chore: Updated tests to confirm behavior of inconsistent offline/online return values#4615
Merged
franciscojavierarceo merged 4 commits intomasterfrom Oct 15, 2024
Merged
Conversation
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
franciscojavierarceo
force-pushed
the
odfv-request-source-bug
branch
from
9f0b585 to
09dee27
Compare
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
robhowley
pushed a commit
to robhowley/feast
that referenced
this pull request
Oct 16, 2024
robhowley
pushed a commit
to robhowley/feast
that referenced
this pull request
Oct 17, 2024
…ne return values (feast-dev#4615) Signed-off-by: Rob Howley <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates
get_historical_featuresto return the requested set of features when ODFVs are called asget_online_features.As outlined in #4479,
get_historical_featuresreturns more features than what is requested when an ODFV is requested.This PR updates:
get_historical_featureswhen calling an ODFV returns only the fields requestedget_historical_featuresis called with an entity that does not have data to calculate an ODFVget_historical_featuresWhich issue(s) this PR fixes:
#4479
Misc
N/A