Skip to content

fix(authentication-client): Ensure reAuthenticate works in parallel with other requests#2690

Merged
daffl merged 1 commit intodovefrom
reauthenticate-parallel
Jul 13, 2022
Merged

fix(authentication-client): Ensure reAuthenticate works in parallel with other requests#2690
daffl merged 1 commit intodovefrom
reauthenticate-parallel

Conversation

@daffl
Copy link
Member

@daffl daffl commented Jul 12, 2022

Running reAuthenticate in parallel with other requests that need authentication e.g. like this:

const [authresult, dummies] = await Promise.all([
  app.reAuthenticate(),
  app.service('dummy').find()
])

Did not work though it should work the same as with authenticate which ensures that all requests wait for the current authentication to complete.

@daffl daffl merged commit 41b3761 into dove Jul 13, 2022
@daffl daffl deleted the reauthenticate-parallel branch July 13, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant