Conversation
Replace the lightweight URLSearchParams-based query-string module with a zero-dependency bracket-notation parser/stringifier that is wire-compatible with qs@6 defaults. This restores support for nested query objects (e.g. $in, $sort) that was lost when the qs npm package was removed. Security hardening against the two main qs CVE classes: - Prototype pollution: __proto__, constructor, prototype keys silently dropped - Memory overflow: array indices >= 2000 silently dropped (no empty shells) Additional safety limits (all set to 2000): - PARAMETER_LIMIT: pairs beyond the limit are dropped - ARRAY_INDEX_LIMIT: array indices >= 2000 are dropped - DEPTH_LIMIT: bracket nesting beyond depth 5 collapses into literal keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URLSearchParams-basedquery-string.tswith a zero-dependency bracket-notation parser/stringifier (qs.ts) that is wire-compatible with qs@6 defaults$in,$sort, etc.) lost when theqsnpm package was removedqsand@types/qsfrom devDependenciessupports nested arrays in queriesintegration test that was removed in feat: Remove qs dependency #3659Safety limits
PARAMETER_LIMITARRAY_INDEX_LIMITDEPTH_LIMIT__proto__,constructor,prototypesilently dropped at every levelTest plan
supports nested arrays in queriesintegration test passes