Feathr Web UI MVP#216
Merged
blrchen merged 27 commits intofeathr-ai:mainfrom May 5, 2022
blrchen:blair/landing-page
Merged
Conversation
This PR enables continues integration and deployment to cloud for ui app - Manually create azure web app under ACE subscription resource group feathr-ui-test - Create github action workflow to trigger deployment on main branch push or pull request - Deploy policy - Main branch will be deployed to https://thankful-mud-0addb6c00.1.azurestaticapps.net/ - Each pull request will be deployed to a staging environment, the url will be generated dynamically n each PR's comment.
jaymo001
reviewed
May 4, 2022
jaymo001
reviewed
May 4, 2022
jaymo001
reviewed
May 4, 2022
jaymo001
reviewed
May 4, 2022
jaymo001
reviewed
May 4, 2022
jaymo001
reviewed
May 4, 2022
jaymo001
reviewed
May 4, 2022
jaymo001
reviewed
May 4, 2022
jaymo001
reviewed
May 4, 2022
Collaborator
|
For foundational PRs, a dev guide is required. You can find some examples : https://github.com/linkedin/feathr/tree/main/docs/dev_guide |
hangfei
reviewed
May 5, 2022
Collaborator
hangfei
left a comment
hangfei
left a comment
There was a problem hiding this comment.
Code documentation is needed for future devs. See https://github.com/linkedin/feathr/blob/main/feathr_project/feathr/client.py as an example.
.github/workflows/azure-static-web-apps-thankful-mud-0addb6c00.yml
Outdated
Show resolved
Hide resolved
xiaoyongzhu
added
the
safe to test
windoze
previously approved these changes
May 5, 2022
blrchen
added
safe to test
This reverts commit 0ca7f07.
Collaborator
|
Thanks for adding the license description. |
Collaborator
Author
|
blrchen
added
safe to test
jaymo001
previously approved these changes
May 5, 2022
jaymo001
approved these changes
May 5, 2022
xiaoyongzhu
approved these changes
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR initialize the fundamental codebase for feathr web UI development, to support following up UX user stories implementation. The codebase is initialized with Create React App, plus following code implementation:
UX framework related implemented
User stories implemented
Docs
Built on
Closes #215