Feathr UI: API spec alignment and ux experience improvement#303
Merged
blrchen merged 9 commits intofeathr-ai:mainfrom Jun 2, 2022
blrchen:blairch/redesign-lineage
Merged
Feathr UI: API spec alignment and ux experience improvement#303blrchen merged 9 commits intofeathr-ai:mainfrom blrchen:blairch/redesign-lineage
blrchen merged 9 commits intofeathr-ai:mainfrom
blrchen:blairch/redesign-lineage
Conversation
blrchen
requested review from
Yuqing-cat,
hangfei,
jaymo001,
windoze and
xiaoyongzhu
Collaborator
|
Overall it's pretty good. Some minor comments:
|
hangfei
reviewed
May 30, 2022
hangfei
reviewed
May 31, 2022
blrchen
changed the title
Merged
blrchen
added
the
safe to test
hangfei
reviewed
Jun 2, 2022
Collaborator
|
Let's not put two distinct commits into one PR in the future. It's harder to review and ensure code quality. There is better way to avoid the problems you mentioned other than merging the commits into one PR. @Yuqing-cat @blrchen |
Collaborator
|
I can't really find the UI changes for RBAC. If it's not accessible from UI, please attach a screenshot. |
Collaborator
Author
RBAC UI is in flgihting, to pilot, plese use this direct url : https://brave-moss-045d2ce00-6.eastasia.1.azurestaticapps.net/management |
hangfei
approved these changes
Jun 2, 2022
xiaoyongzhu
approved these changes
Jun 2, 2022
bozhonghu
pushed a commit
that referenced
this pull request
Jun 2, 2022
* main: added init py for import error (#308) add contribution text (#153) Add 'feathr hocon' command (#317) Feathr UI: API spec alignment and ux experience improvement (#303) bump version (#315) Adding custom data loader handler support. (#309) Update product_recommendation_demo.ipynb Update product_recommendation_demo.ipynb Product sample (#314) [Feathr] Add a example for product recommendation (#312)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR update ui code to align with latest api spec which abstracts common interfaces among different registration providers. This PR also enhances lineage ux experience and adds RBAC experience for flighting.
Staging env: https://brave-moss-045d2ce00-6.eastasia.1.azurestaticapps.net/
New Feature registration API integration
API spec can be viewed at https://feathr-registry.azurewebsites.net/docs. UI code is now purview free.
UX improvements
Linked issue: #272