Use elegant way to get all features for a project and fix potential concurrency issues#368
Closed
xiaoyongzhu wants to merge 11 commits intomainfrom
Closed
Use elegant way to get all features for a project and fix potential concurrency issues#368xiaoyongzhu wants to merge 11 commits intomainfrom
xiaoyongzhu wants to merge 11 commits intomainfrom
Conversation
hangfei
approved these changes
Jun 18, 2022
YihuiGuo
reviewed
Jun 21, 2022
Member
Author
|
#466 the issues should already be fixed by this PR hence closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a few comments/issues:
search_entitiesmethod, which might not be scalable when there are tons of entities (or might take some time)This PR solves those two issues, by doing the following:
lineageAPI to get all the entities belonging to a certain project at once, so that we don't have to do search, rather we rely on the pre-computed purview lineage to get all the entitiesget_features_from_registry(), we don't use the attributes since there might be concurrency issues; Instead, we useAtlasProcessto avoid potential concurrency issues.Also fixed an issue brought by #380 where additional schema is added.