Merged
Conversation
xiaoyongzhu
requested review from
Yuqing-cat,
blrchen,
edwincheung,
hangfei,
jainr,
jaymo001 and
windoze
blrchen
previously approved these changes
Jun 27, 2022
Yuqing-cat
reviewed
Jun 28, 2022
Collaborator
Yuqing-cat
left a comment
Yuqing-cat
left a comment
There was a problem hiding this comment.
Not quite understand the when would you need a feature store section. It may let users think feature store can only host one use case, which is not true.
And for the face recognition sample, is it trying to refer to a single data source use case? Why can't it leverage Feathr to manage its feature generation?
blrchen
approved these changes
Jul 8, 2022
Yuqing-cat
approved these changes
Jul 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes typos in the docs, update the formats for many of the tables (hopefully can fix #377). This document fix doesn't include content changes.