New Purview Registry adapt Sql data model#404
Merged
Yuqing-cat merged 6 commits intofeathr-ai:mainfrom Jul 4, 2022
YihuiGuo:yihui/purview_registry
Merged
New Purview Registry adapt Sql data model#404Yuqing-cat merged 6 commits intofeathr-ai:mainfrom YihuiGuo:yihui/purview_registry
Yuqing-cat merged 6 commits intofeathr-ai:mainfrom
YihuiGuo:yihui/purview_registry
Conversation
xiaoyongzhu
reviewed
Jun 30, 2022
xiaoyongzhu
reviewed
Jun 30, 2022
xiaoyongzhu
reviewed
Jun 30, 2022
blrchen
approved these changes
Jul 4, 2022
Yuqing-cat
approved these changes
Jul 4, 2022
Collaborator
Yuqing-cat
left a comment
There was a problem hiding this comment.
Please make more e2e test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #387
Add purview registry.
Keep sql registry code unchanged to avoid conflict.
Conform to Registy interfaces, provide same method and data format.
NOTICE that :
This PR does not totally eliminate the risk of concurrent conflict.
In old version, we update all entities like
purviewclient.upload_entities([entity_batch])In this PR, several changes has been applied to shrink the time window for a concurrent race condition to happen:
Limitations:
By applying changes above to purview registry, the time window for a race condition to happen shrinks, but not eliminated.
A complete change needs discussion with Purview team about recommended way to secure MVCC.