Conversation
xiaoyongzhu
requested review from
Yuqing-cat,
blrchen,
hangfei,
jainr and
jaymo001
The doc for get_offline_features uses product recommendation data but the doc for materilizate_features uses NYC taxi data. This might confuse readers. I know consolidate this mgiht not be intention of this PR am okay this be addressed in different PR. Refers to: docs/concepts/materializing-features.md:44 in 85a1c44. [](commit_id = 85a1c44, deletion_comment = False) |
Yeah we need to update all the samples quite a bit so let's do it in a separate PR. |
* Update README.md * update docs per feedback * Update feathr-concepts-for-beginners.md * Update feathr-concepts-for-beginners.md * update materialization setting doc * Update get-offline-features.md * Update get-offline-features.md * Update feathr-concepts-for-beginners.md * resolve comments * Update job_utils.py * fix typos * Update job_utils.py * Update client.py * format doc * Address comments * Update WriteToHDFSOutputProcessor.scala * Update WriteToHDFSOutputProcessor.scala * resolve comments * Resolve comments * fix test failures and typos * Update job_utils.py * fix comments and formats/typos * fix typos and test failures * update test names * Update test_fixture.py * Update test_fixture.py
3 participants
Various documentation fix per feedback from end users, covering those issues:
#437
#464
#461
#473 (part of it)
This PR also rewrites the feature join doc, fixing various typos, and add csv support for
get_result_dfhelper function per one of user's feedback.