Merged
Conversation
jaymo001
reviewed
Aug 1, 2022
src/main/scala/com/linkedin/feathr/offline/source/pathutil/LocalPathChecker.scala
Outdated
Show resolved
Hide resolved
Fixing a bug where external data paths don't accidently trigger the HDFS path when executing local path logic.
blee1234
force-pushed
the
data_path_handler_local_path_bug_fix
branch
from
733509d to
c2b13ea
Compare
blee1234
force-pushed
the
data_path_handler_local_path_bug_fix
branch
3 times, most recently
from
5e8c50e to
c945001
Compare
blee1234
force-pushed
the
data_path_handler_local_path_bug_fix
branch
from
c945001 to
8fc6a25
Compare
jaymo001
approved these changes
Aug 2, 2022
xiaoyongzhu
approved these changes
Aug 3, 2022
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
* DataPathHandler Bug Fix Fixing a bug where external data paths don't accidently trigger the HDFS path when executing local path logic. * Refactored isHdfs to isExternalDataSource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a bug where external data paths don't accidentally trigger the HDFS path when executing local path logic.
Namely with LocalPathChecker, it needs to have logic to identify when a path isn't HDFS and thus will not invoke HdfsUtils.exists, which currently throws an exception when non HDFS local paths get passed in.