Extend Access Control Registry APIs to protect post ones#551
Merged
Yuqing-cat merged 2 commits intofeathr-ai:mainfrom Aug 4, 2022
Merged
Extend Access Control Registry APIs to protect post ones#551Yuqing-cat merged 2 commits intofeathr-ai:mainfrom
post ones#551Yuqing-cat merged 2 commits intofeathr-ai:mainfrom
Conversation
Yuqing-cat
added
safe to test
xiaoyongzhu
approved these changes
Aug 4, 2022
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
…#551) * Extend rbac registry APIs to post ones * Update auth.py to support live.com CLI tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included In This PR:
postAPIs validated in localhostThe rest
postAPIs should have the similar behavior withcreate datasource.globalkeyword protection and400exception classThis PR should be able to unblock the
feathrclientsql issue with rbac registry endpoints.Todo in follow up PRs:
HttpExceptionsinto a seperateexpection.py