Conversation
xiaoyongzhu
approved these changes
Aug 16, 2022
hangfei
reviewed
Aug 16, 2022
hangfei
approved these changes
Aug 16, 2022
d4ve
reviewed
Aug 17, 2022
| @transient private lazy val parserContext = MvelContext.newParserContext | ||
|
|
||
| private val keyExpression = key.map(k => MVEL.compileExpression(k, parserContext)) | ||
| private val keyExpression = if (key == null) Seq() else key.map(k => MVEL.compileExpression(k, parserContext)) |
Collaborator
There was a problem hiding this comment.
What is the meaning of the Seq() case here? Can you explain it in a quick comment in the code
Comment on lines
+4
to
+9
| /** | ||
| * The metadata for FeaturizedDataset | ||
| * @param meta extra metadata | ||
| * @param header feature type header info | ||
| */ | ||
| case class FeaturizedDatasetMetadata(meta: Map[String, String] = Map(), header: Option[Header] = None ) { |
Collaborator
There was a problem hiding this comment.
Should be more docs about what this means; what a featurized-dataset is? (Do we have docs about it in this public version of feathr? Should we just call it as feathr's output dataset that includes info about the tensor types of joined features...?)
Also, what does "extra metadata" mean; what kinds of things is the map allowed/expected to contain, what are the keys, values, etc.
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes multiple minor issues related to Feathr backward compatibility.
Does this PR introduce any user-facing changes?
No.