Skip to content

UI: Add home page and project list page#595

Merged
xiaoyongzhu merged 4 commits intomainfrom
blair/ui
Aug 24, 2022
Merged

UI: Add home page and project list page#595
xiaoyongzhu merged 4 commits intomainfrom
blair/ui

Conversation

@blrchen
Copy link
Collaborator

@blrchen blrchen commented Aug 22, 2022 •
edited
Loading

Description

This PR adds two new page in web UI:

  • Home: a new home page provider quick links to projects, sources and features page, this page also provider links for user for getting started.
  • Projects: a new project list page to allow user explore projects and quickly navigate to project feature list / lineage page.

Staging url to preview this PR: https://brave-moss-045d2ce00.1.azurestaticapps.net/

How was this PR tested?

Test two newly added UI can display correctly in local devbox

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@blrchen blrchen requested a review from donegjookim as a code owner August 22, 2022 16:35
@xiaoyongzhu
Copy link
Member

xiaoyongzhu commented Aug 22, 2022

@blrchen can you paste a few screenshots?

@hangfei
Copy link
Collaborator

hangfei commented Aug 22, 2022

Thanks for the PR.

Could you add instructions on how to view your changes in website or screenshots?

@blrchen
Copy link
Collaborator Author

blrchen commented Aug 23, 2022

I added the staging url in PR description. @hangfei @xiaoyongzhu

@xiaoyongzhu
Copy link
Member

xiaoyongzhu commented Aug 23, 2022

A few comments:

  1. seems the lineage UI is wrong. I saw this in previous snapshot so not sure if this is in the UI layer or not

https://brave-moss-045d2ce00.1.azurestaticapps.net/projects/feathr_ci_registry_9_14_711429/lineage

  1. I remember we added the management page in the side bar before?

@blrchen
Copy link
Collaborator Author

blrchen commented Aug 23, 2022

A few comments:

  1. seems the lineage UI is wrong. I saw this in previous snapshot so not sure if this is in the UI layer or not

https://brave-moss-045d2ce00.1.azurestaticapps.net/projects/feathr_ci_registry_9_14_711429/lineage

  1. I remember we added the management page in the side bar before?

@xiaoyongzhu , 1 is a known issue addressed in PR #593 , 2 is expected as this staging site does not have rbac enabled on backend. Currently management menu is only visible when backend has rbac enabled.

@xiaoyongzhu
Copy link
Member

xiaoyongzhu commented Aug 23, 2022

A few comments:

  1. seems the lineage UI is wrong. I saw this in previous snapshot so not sure if this is in the UI layer or not

https://brave-moss-045d2ce00.1.azurestaticapps.net/projects/feathr_ci_registry_9_14_711429/lineage

  1. I remember we added the management page in the side bar before?

@xiaoyongzhu , 1 is a known issue addressed in PR #593 , 2 is expected as this staging site does not have rbac enabled on backend. Currently management menu is only visible when backend has rbac enabled.

I see, thanks!

@jainr jainr self-requested a review August 23, 2022 22:22
@xiaoyongzhu xiaoyongzhu merged commit 3e61f3b into main Aug 24, 2022
@xiaoyongzhu xiaoyongzhu deleted the blair/ui branch August 24, 2022 02:16
ahlag pushed a commit to ahlag/feathr that referenced this pull request Aug 26, 2022
@blrchen @ahlag
UI: Add home page and project list page (feathr-ai#595)
b40b19d 
* Add home page and project list page

* Fix responsive issue

* Add a view feature action link in project list page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@jainr jainr jainr approved these changes

@donegjookim donegjookim Awaiting requested review from donegjookim donegjookim is a code owner

@hangfei hangfei Awaiting requested review from hangfei

@windoze windoze Awaiting requested review from windoze

@Yuqing-cat Yuqing-cat Awaiting requested review from Yuqing-cat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blrchen @xiaoyongzhu @hangfei @jainr