Fix source entity missing time window bug.#600
Merged
xiaoyongzhu merged 1 commit intofeathr-ai:mainfrom Aug 23, 2022
YihuiGuo:yihui/fix_missing_window_in_source
Merged
Fix source entity missing time window bug.#600xiaoyongzhu merged 1 commit intofeathr-ai:mainfrom YihuiGuo:yihui/fix_missing_window_in_source
xiaoyongzhu merged 1 commit intofeathr-ai:mainfrom
YihuiGuo:yihui/fix_missing_window_in_source
Conversation
xiaoyongzhu
approved these changes
Aug 23, 2022
windoze
approved these changes
Aug 23, 2022
Collaborator
|
Is camel casing required for backward compatibility? |
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug is about source entity missing time window information. turns out timestamp column and timestamp format.
These properties are lost when saving to purview.
Add these columns back, to avoid breaking other pipeline, do not remove these camel case properties.