Expose deletion API for projects/features#852
Conversation
merge main to feature branch
aabbasi-hbo
left a comment
There was a problem hiding this comment.
@xiaoyongzhu is there a reason why the registry purview client (https://github.com/feathr-ai/feathr/blob/main/feathr_project/feathr/registry/_feature_registry_purview.py) does not call the API specified in (https://github.com/feathr-ai/feathr/blob/main/registry/purview-registry/main.py)? It seems that API functionality has been directly implemented in the client
Nevermind I see that it is deprecated |
|
Thanks @aabbasi-hbo for the PR! This is very helpful. |
|
Cascading deletion seems to be a too-dangerous operation, could we have some safer alternatives? |
@windoze which cascading operation are you referring to? The deletion uses the BFS function to get all downstream entities and deletes them through another BFS |
|
'Cascading" means one delete request could actually delete a lot of entities without any prior notice, which could be too dangerous. |
got it. yeah that makes sense - will update. Thanks for the feedback! |
aabbasi-hbo
left a comment
There was a problem hiding this comment.
@windoze mind reviewing again when you get a chance? thanks!
windoze
left a comment
There was a problem hiding this comment.
It looks good to me, thanks for a great job.
Sorry for the delay, I was working on something else. Thanks for the contribution! |
xiaoyongzhu
left a comment
There was a problem hiding this comment.
This is a really nice PR, thanks for the contribution!
* registry-changes * update purview * remove delete functionality for now * update tests * remove unused import * update endpoints * fix locking issue * Update _feature_registry_purview.py * remove cascading delete * Update feature_registry.py * update access control * update status code to 412
Description
Resolves #842
Exposes the deletion API for features/projects
How was this PR tested?
Updated unit tests
Does this PR introduce any user-facing changes?