Add 'postfixPath' to support time pattern in the middle of paths#858
Merged
enya-yx merged 14 commits intofeathr-ai:mainfrom Dec 2, 2022
Merged
Add 'postfixPath' to support time pattern in the middle of paths#858enya-yx merged 14 commits intofeathr-ai:mainfrom
enya-yx merged 14 commits intofeathr-ai:mainfrom
Conversation
Add postfix test cases for databricks
xiaoyongzhu
reviewed
Nov 23, 2022
xiaoyongzhu
reviewed
Nov 23, 2022
xiaoyongzhu
reviewed
Nov 23, 2022
xiaoyongzhu
reviewed
Nov 23, 2022
xiaoyongzhu
reviewed
Nov 23, 2022
xiaoyongzhu
reviewed
Nov 23, 2022
Member
|
Thanks @enya-yx for this PR, this looks good to me other than some minor comments on the duplicated code/naming conventions. |
2 tasks
xiaoyongzhu
reviewed
Nov 25, 2022
xiaoyongzhu
reviewed
Nov 28, 2022
xiaoyongzhu
reviewed
Nov 28, 2022
xiaoyongzhu
reviewed
Nov 28, 2022
xiaoyongzhu
reviewed
Nov 28, 2022
xiaoyongzhu
approved these changes
Dec 2, 2022
Member
xiaoyongzhu
left a comment
There was a problem hiding this comment.
The test failures seem should to be irrelevant
windoze
approved these changes
Dec 2, 2022
jaymo001
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Add 'postfixPath' to support time pattern in the middle of paths * Expose 'postfix_path' to datasource API * Add test cases & documents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How was this PR tested?