Add feature embedding example#881
Merged
xiaoyongzhu merged 4 commits intofeathr-ai:mainfrom Dec 2, 2022
Merged
Conversation
Signed-off-by: Jun Ki Min <[email protected]>
xiaoyongzhu
previously approved these changes
Nov 28, 2022
Collaborator
Author
|
Hi team, I added "Samples" section to docs/README.md describing about sample notebooks. |
Signed-off-by: Jun Ki Min <[email protected]>
loomlike
added
the
safe to test
Signed-off-by: Jun Ki Min <[email protected]>
blrchen
approved these changes
Dec 1, 2022
Collaborator
blrchen
left a comment
blrchen
left a comment
There was a problem hiding this comment.
Thanks Jun, this is a nice PR!
xiaoyongzhu
approved these changes
Dec 2, 2022
jaymo001
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Add feature embedding example. Update README Signed-off-by: Jun Ki Min <[email protected]> * Add feature embedding notebook test Signed-off-by: Jun Ki Min <[email protected]> * increase notebook's spark job timeout Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Jun Ki Min <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jun Ki Min [email protected]
Description
This PR includes:
How was this PR tested?
pytest under test/samples
Feature registration part is bypassed.
Once we support proper cleanup features, I can add the registration tests as well (#880).
Does this PR introduce any user-facing changes?