Add FIRST aggregation for look up feature#917
Merged
xiaoyongzhu merged 1 commit intofeathr-ai:mainfrom Jan 5, 2023
Merged
Conversation
jaymo001
added
the
safe to test
bozhonghu
approved these changes
Dec 19, 2022
Collaborator
bozhonghu
left a comment
bozhonghu
left a comment
There was a problem hiding this comment.
LGTM. Should make it clear in documentation this should only be used if there is a single value and also make it clear this is only available in offline and not in online.
xiaoyongzhu
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, users are relying on UNION aggregation based look up feature, followed by a derived feature to pick the first value, when there is only one looked up feature value and the user wants to keep the look up feature value type the same as input.
This PR adds FIRST aggregation for look up feature so that users can skip the derived feature definition for such tasks.
How was this PR tested?
Add test case