Updating automated maven publish workflow to work with gradle creds#979
Merged
jainr merged 1 commit intofeathr-ai:mainfrom Jan 18, 2023
Merged
Updating automated maven publish workflow to work with gradle creds#979jainr merged 1 commit intofeathr-ai:mainfrom
jainr merged 1 commit intofeathr-ai:mainfrom
Conversation
jainr
requested review from
Yuqing-cat,
blrchen,
mufajjul,
rakeshkashyap123 and
xiaoyongzhu
jainr
added
the
safe to test
Collaborator
rakeshkashyap123
left a comment
rakeshkashyap123
left a comment
There was a problem hiding this comment.
The changes look good to me. Can you comment on how we are planning to test it? Is it only upon checkin?
Yuqing-cat
approved these changes
Jan 18, 2023
Collaborator
Author
Once the PR is checked in, delete one of the tags, recreate it and that should trigger a build. |
rakeshkashyap123
approved these changes
Jan 18, 2023
xiaoyongzhu
added a commit
to xiaoyongzhu/feathr
that referenced
this pull request
Jan 19, 2023
…using gradle plugin (feathr-ai#979)" This reverts commit c0b38d5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The gradle plugin being used to build and publish jar to maven central requires that credentials be passed a certain way.
As documented here- https://vanniktech.github.io/gradle-maven-publish-plugin/central/#secrets
How was this PR tested?
Will Test it as part of PR workflow.
Does this PR introduce any user-facing changes?