feat(firestore, web): migrate web to js_interop to be compatible with WASM#12169
Merged
feat(firestore, web): migrate web to js_interop to be compatible with WASM#12169
Conversation
exaby73
approved these changes
Jan 22, 2024
russellwheatley
requested changes
Jan 23, 2024
Member
russellwheatley
left a comment
russellwheatley
left a comment
There was a problem hiding this comment.
Left a small comment but LGTM
Comment on lines
+39
to
+65
| Uint8List buffer = await loadBundleSetup(2); | ||
| LoadBundleTask task = firestore.loadBundle(buffer); | ||
|
|
||
| final list = await task.stream.toList(); | ||
|
|
||
| print( | ||
| list.map((e) => e.totalDocuments), | ||
| ); | ||
| print( | ||
| list.map((e) => e.bytesLoaded), | ||
| ); | ||
| print( | ||
| list.map((e) => e.documentsLoaded), | ||
| ); | ||
| print( | ||
| list.map((e) => e.totalBytes), | ||
| ); | ||
| print( | ||
| list, | ||
| ); | ||
|
|
||
| LoadBundleTaskSnapshot lastSnapshot = list.removeLast(); | ||
| print(lastSnapshot.taskState); | ||
|
|
||
| print( | ||
| list.map((e) => e.taskState), | ||
| ); |
Member
There was a problem hiding this comment.
Perhaps remove or put into an ElevatedButton (or something similar) if we want to demonstrate how it works 👍
Contributor
Author
There was a problem hiding this comment.
Yes it was definitely something that I forgot to move :) Thanks for noticing
russellwheatley
approved these changes
Jan 24, 2024
Contributor
There was a problem hiding this comment.
@Lyokone is there a reason that js is still listed as dependency, or was this just missed in the PR?
There seem to be no more usages here:
https://github.com/search?q=repo%3Afirebase%2Fflutterfire+path%3A%2F%5Epackages%5C%2Fcloud_firestore%5C%2F%2F+dart%3Ajs&type=code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
#12027
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?