Skip to content

[firebase_core_web] Add initial implementation#1488

Merged
harryterkelsen merged 10 commits intofirebase:masterfrom
harryterkelsen:implement-firebase-core-web
Nov 28, 2019
Merged

[firebase_core_web] Add initial implementation#1488
harryterkelsen merged 10 commits intofirebase:masterfrom
harryterkelsen:implement-firebase-core-web

Conversation

@harryterkelsen
Copy link

@harryterkelsen harryterkelsen commented Nov 23, 2019

Description

This adds web support to firebase_core_web.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

ditman
ditman reviewed Nov 26, 2019
View reviewed changes
ditman
ditman reviewed Nov 26, 2019
View reviewed changes
ditman
ditman approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I checked, we didn't want people using dart:js/dart:js_util directly unless they were in the places where you can't use package: deps. I think you should port this to using package:js deps (I suggested a couple of changes, that may help)

@harryterkelsen
Copy link
Author

harryterkelsen commented Nov 27, 2019

You're right. We should prefer package:js over dart:js for packages. Thanks for the review! PTAL

@harryterkelsen harryterkelsen mentioned this pull request Nov 27, 2019
Closed
ditman
ditman approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the dummy ios/firebase_core_web.podspec file in this package so we don't break compilation on IOS?

@ditman
Copy link
Contributor

ditman commented Nov 27, 2019

(There's also scripts similar to flutter/plugins so we might need to exclude the platform_interface from here: https://github.com/FirebaseExtended/flutterfire/blob/master/script/build_all_plugins_app.sh#L15 ?)

@harryterkelsen
Copy link
Author

harryterkelsen commented Nov 27, 2019

Added a dummy podspec. It looks like firebase_core is already excluded from the build_all_plugins script

@harryterkelsen
Copy link
Author

harryterkelsen commented Nov 28, 2019

Merging despite failing tests on stable since web plugins aren't supported on stable.

@harryterkelsen harryterkelsen merged commit b498372 into firebase:master Nov 28, 2019
@firebase firebase locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@collinjackson collinjackson Awaiting requested review from collinjackson

1 more reviewer

@ditman ditman ditman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[firebase_core] Support firebase_core on the web.

4 participants

@harryterkelsen @ditman @collinjackson @googlebot