Skip to content

[cloud_firestore] Endorse cloud_firestore_web.#1977

Merged
ditman merged 2 commits intofirebase:masterfrom
ditman:endorse-firestore-web
Feb 11, 2020
Merged

[cloud_firestore] Endorse cloud_firestore_web.#1977
ditman merged 2 commits intofirebase:masterfrom
ditman:endorse-firestore-web

Conversation

@ditman
Copy link
Contributor

@ditman ditman commented Feb 10, 2020

Description

This change endorses cloud_firestore_web as the official implementation of cloud_firestore for the Web target.

It also adds web support to the example app.

Related Issues

Fixes flutter/flutter#45293

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@amrfarid140 @ditman
[cloud_firestore] Endorse cloud_firestore_web.
6a18a5a 
This change makes `cloud_firestore_web` the official implementation of
`cloud_firestore` for the Web target.
@amrfarid140 @ditman
[cloud_firestore] Add web support to the example app.
61ef20b
@ditman ditman requested a review from collinjackson February 10, 2020 23:56
@ditman ditman self-assigned this Feb 10, 2020
@googlebot
Copy link

googlebot commented Feb 10, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@ditman
Copy link
Contributor Author

ditman commented Feb 10, 2020

Hey @amrfarid140, do you consent us endorsing cloud_firestore_web as the official implementation? (see this comment) :)

@amrfarid140
Copy link
Contributor

amrfarid140 commented Feb 11, 2020

@googlebot I consent.

@googlebot
Copy link

googlebot commented Feb 11, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ditman
Copy link
Contributor Author

ditman commented Feb 11, 2020

(Thanks @amrfarid140! I'm merging this during the workday tomorrow, Pacific Time)

collinjackson
collinjackson approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ditman ditman merged commit 1d55c96 into firebase:master Feb 11, 2020
@ditman ditman deleted the endorse-firestore-web branch February 11, 2020 20:14
@ditman
Copy link
Contributor Author

ditman commented Feb 11, 2020

Merged and published cloud_firestore 0.13.2.

@firebase firebase locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@collinjackson collinjackson collinjackson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ditman ditman

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cloud_firestore] Add support for web

4 participants

@ditman @googlebot @amrfarid140 @collinjackson