Skip to content

feat(ui): Add Bahasa Indonesia localization language support#7709

Merged
russellwheatley merged 9 commits intofirebase:masterfrom
ekasetiawans:master
Feb 15, 2022
Merged

feat(ui): Add Bahasa Indonesia localization language support#7709
russellwheatley merged 9 commits intofirebase:masterfrom
ekasetiawans:master

Conversation

@ekasetiawans
Copy link
Contributor

@ekasetiawans ekasetiawans commented Dec 27, 2021 •
edited
Loading

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@ekasetiawans ekasetiawans changed the title added bahasa (indonesia) languange (flutterfire_ui) added bahasa (indonesia) languange Dec 27, 2021
@ekasetiawans ekasetiawans changed the title (flutterfire_ui) added bahasa (indonesia) languange feat(flutterfire_ui) added bahasa (indonesia) languange Dec 27, 2021
@ekasetiawans ekasetiawans changed the title feat(flutterfire_ui) added bahasa (indonesia) languange feat: (flutterfire_ui) added bahasa (indonesia) languange Dec 27, 2021
@lesnitsky lesnitsky self-assigned this Jan 4, 2022
@Salakar Salakar changed the title feat: (flutterfire_ui) added bahasa (indonesia) languange feat(ui): add Bahasa Indonesia localization support Jan 4, 2022
lesnitsky
lesnitsky reviewed Jan 13, 2022
View reviewed changes
lesnitsky
lesnitsky reviewed Jan 13, 2022
View reviewed changes
lesnitsky
lesnitsky suggested changes Jan 13, 2022
View reviewed changes
Copy link
Member

@lesnitsky lesnitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataTable labels require translations

@ekasetiawans
Copy link
Contributor Author

ekasetiawans commented Jan 13, 2022

@lesnitsky i did it

ekasetiawans
ekasetiawans commented Jan 27, 2022
View reviewed changes
Copy link
Contributor Author

@ekasetiawans ekasetiawans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

ekasetiawans
ekasetiawans commented Feb 7, 2022
View reviewed changes
Copy link
Contributor Author

@ekasetiawans ekasetiawans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@ekasetiawans
Copy link
Contributor Author

ekasetiawans commented Feb 12, 2022

why hasn't this PR been merged? is there something i forgot?

@russellwheatley
Copy link
Member

russellwheatley commented Feb 15, 2022

Hey @ekasetiawans, thanks for the PR! I don't suppose you are able to have your Bahasa Indonesia double checked by someone who speaks the language (i.e get this PR approved by a developer who speaks the language)? Just for spellchecking and correct language interpretation. Sadly, I don't know anyone from Indonesia 😄

@ekasetiawans
Copy link
Contributor Author

ekasetiawans commented Feb 15, 2022

@russellwheatley do you mean anyone from Indonesia or just for collaboratos from Indonesia?

@russellwheatley
Copy link
Member

russellwheatley commented Feb 15, 2022

@ekasetiawans, someone you know would be fine. I prefer a proofreading whenever there's a labelling/documentation PR.

@ekasetiawans
Copy link
Contributor Author

ekasetiawans commented Feb 15, 2022

@russellwheatley I'm very new to open source collaboration, so I need some guidance in case something goes wrong.

@RTheTopanX404
Copy link

RTheTopanX404 commented Feb 15, 2022

@ekasetiawans ..
I'm already check all of translations to Indonesia, and everything is translated to Indonesia .

@russellwheatley russellwheatley changed the title feat(ui): add Bahasa Indonesia localization support feat(ui): Add Bahasa Indonesia localization language support Feb 15, 2022
@russellwheatley russellwheatley merged commit be0eb27 into firebase:master Feb 15, 2022
@adityathakurxd adityathakurxd mentioned this pull request Feb 23, 2022
Merged
10 tasks
@firebase firebase locked and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lesnitsky lesnitsky lesnitsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lesnitsky lesnitsky

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ekasetiawans @russellwheatley @RTheTopanX404 @lesnitsky @Salakar