Skip to content

cfg for new experimental root hash#890

Merged
ZanCorDX merged 3 commits intodevelopfrom
dx/root-hash-exp-cfg
Mar 6, 2026
Merged

cfg for new experimental root hash#890
ZanCorDX merged 3 commits intodevelopfrom
dx/root-hash-exp-cfg

Conversation

@ZanCorDX
Copy link
Collaborator

@ZanCorDX ZanCorDX commented Mar 6, 2026

📝 Summary

Read the tittle.

💡 Motivation and Context

Tried to configure it via telepathy but didn't work.

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@ZanCorDX ZanCorDX requested a review from dvush as a code owner March 6, 2026 17:06
@claude
Copy link
Contributor

claude bot commented Mar 6, 2026

Claude finished @ZanCorDX's task in 1m 3s —— View job


Review: cfg for new experimental root hash

  • Gather context
  • Review changes
  • Post review

Summary: This is a 1-line change that adds "vexp" as a config option mapping to ETHSpareMPTVersion::VExperimental in the live_root_hash_config() match arm. The change itself is correct — VExperimental exists in the enum and is fully wired up in eth-sparse-mpt.

One minor issue flagged inline: the error message on the fallback _ arm still says "can be v1 or v2" and should be updated to include vexp.

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
@claude
Copy link
Contributor

claude bot commented Mar 6, 2026

Claude finished @ZanCorDX's task in 35s —— View job


Review: cfg for new experimental root hash

  • Gather context
  • Review changes
  • Post review

No issues found. The previous review's suggestion (updating the error message to include vexp) has been applied in commit 545c7ed. The change is minimal and correct — it adds "vexp" mapping to ETHSpareMPTVersion::VExperimental in the config match arm, and the error message now properly lists all three options.

@claude
Copy link
Contributor

claude bot commented Mar 6, 2026

Claude finished @ZanCorDX's task in 47s —— View job


Review: cfg for new experimental root hash

  • Gather context
  • Review changes
  • Post review

No issues found. The PR is split into two concerns:

  1. Config change (base_config.rs): Adds "vexp"ETHSpareMPTVersion::VExperimental mapping with updated error message. Clean and correct.

  2. Lint suppression (remaining 6 files): Adds #[allow(clippy::result_large_err)] and #[allow(clippy::manual_saturating_arithmetic)] attributes to suppress new clippy warnings. These are reasonable — the result_large_err warnings are on closures/functions where changing the error type would be a larger refactor, and the manual_saturating_arithmetic ones are in block-building context code where the existing checked arithmetic is intentional.

No bugs, security issues, or performance concerns.

@ZanCorDX ZanCorDX merged commit 8d5a3fd into develop Mar 6, 2026
7 checks passed
@ZanCorDX ZanCorDX deleted the dx/root-hash-exp-cfg branch March 6, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants