Skip to content

Builder name always needed on rbuilder-operator#897

Merged
ZanCorDX merged 1 commit intodevelopfrom
dx/builder-name-always-needed
Mar 16, 2026
Merged

Builder name always needed on rbuilder-operator#897
ZanCorDX merged 1 commit intodevelopfrom
dx/builder-name-always-needed

Conversation

@ZanCorDX
Copy link
Collaborator

📝 Summary

Builder name always needed on rbuilder-operator

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@ZanCorDX ZanCorDX requested a review from dvush as a code owner March 16, 2026 17:12
@claude
Copy link
Contributor

claude bot commented Mar 16, 2026

Claude finished @ZanCorDX's task in 58s —— View job


Review of PR #897

  • Read the diff and changed files
  • Analyze changes and provide review

Changes: Adds an early validation in FlashbotsConfig::new_builder that bails if builder_name is empty.

No issues found. The change is minimal and correct:

  • The builder_name field is a String with no serde default, so the only way it can be empty is if it's explicitly set to "" in config — this check catches that case with a clear error message.
  • The validation is placed at the top of new_builder, failing fast before any resource allocation, which is the right pattern.
  • Consistent with the existing validation style (e.g., the relay_bid_scrapers.is_empty() check on line 170).

LGTM — no concerns.

@ZanCorDX ZanCorDX merged commit 3d19594 into develop Mar 16, 2026
9 of 10 checks passed
@ZanCorDX ZanCorDX deleted the dx/builder-name-always-needed branch March 16, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants