Improve desktop/mouse scroll#1118
Conversation
|
Looking good! Haven't had much experience with this library on the web, but this looks nice from the .gif you added. Just wondering out loud, could the removal of the debounce cause unintended side effects? |
|
@JaffaKetchup it seems debounce effect was introduced to limit number of zoom changes on scroll. Image loading is limited anyway by I'm testing both on desktop (Mac) and web (Safari/Chrome/Opera). |
|
@kengu @johnpryan would you mind taking a look? |
There was a problem hiding this comment.
LGTM, as long as this doesn't cause unnecessary processing stress. Just waiting on maintainers to return or people to be given write access. See #1117.
EDIT: Also see my comment below.
JaffaKetchup
left a comment
JaffaKetchup
left a comment
There was a problem hiding this comment.
With those changes, LGTM I think.
|
Thanks for the heads up @JaffaKetchup. We've decided to release our app with a fork attached (not to block release). You could test the new scroll behaviour here: Fingers crossed for write access and getting this merged. It really improves the experience on desktop and web. |
|
No problem :). Can't look at the website right now, as I'm on mobile and these changes don't affect the pinch gesture AFAIK. Hoping for merge too! |
|
@marcin-jelenski Please pull upstream when possible, then I (or another maintainer) can merge after running the checks. |
|
@JaffaKetchup done, updated with upstream. |
|
@marcin-jelenski Many thanks :) |
|
@JaffaKetchup done - formatting fixed. |
2 participants
The current mouse scroll is laggy.
Let's remove debounce method and use float zoom.
Tested on a physical mouse (Logitech) and MacBook touchpad.
Also fixed #1079