Add flutter-pub-roller-bot to list of auto_approval_accounts#25
Merged
christopherfujino merged 1 commit intomainfrom Jul 7, 2023
Merged
Add flutter-pub-roller-bot to list of auto_approval_accounts#25christopherfujino merged 1 commit intomainfrom
christopherfujino merged 1 commit intomainfrom
Conversation
Add flutter-pub-roller-bot to list of auto_approval_accounts as part of flutter/flutter#129847
10 tasks
Contributor
|
By adding this to the $org/.github repo this will apply to all flutter repos. Is that what is intended here? |
Contributor
Author
|
@ricardoamador I would be ok with moving this to the framework repo config--however, from reading the source, it looked to me like only the org-level config was checked when determining the auto approval accounts via:
Am I missing the point where we check the repo-scoped config? |
Contributor
|
If you add the allow-override flag it will check the local repo. But it might not matter if this bot only operates in the flutter repo autosubmit won't care unless it is in flutter. No big deal. |
Contributor
Author
|
Ahh, I see, looks like it grabs it here: https://github.com/flutter/cocoon/blob/main/auto_submit/lib/configuration/repository_configuration_manager.dart#L85C17-L85C17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#129847
Add bot account: https://github.com/flutter-pub-roller-bot