Merged
Conversation
Hixie
reviewed
Feb 24, 2021
bin/generate.dart
Outdated
| if (jobs.any(_hasJobFailed)) { | ||
| // We're already printing the error message. All that's left is set | ||
| // the exit code. | ||
| exitCode = 1; |
Contributor
There was a problem hiding this comment.
can you return 1 here and have the exitCode be set outside this? In general code is easier to reason about if it does not cause changes outside of its own state.
Contributor
Author
There was a problem hiding this comment.
Done. Consolidated error reporting into GeneratorException.
Hixie
approved these changes
Feb 24, 2021
Contributor
Hixie
left a comment
Hixie
left a comment
There was a problem hiding this comment.
LGTM modulo minor comments
yjbanov
force-pushed
the
filter-quality-asset
branch
from
3956079 to
c50fb19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a diagram showing the effect of
FilterQualityon scaled images.Bonus: exit with a non-zero code when any of the worker jobs fail.