Conversation
|
Requesting @gspencergoog for review, since he is responsible for adding |
|
We use mp4s and ffmpeg because the files are smaller, and the quality is much better, and we can also do higher frame rates if we want to. Why would we want to use GIFs? |
|
@gspencergoog |
|
@HansMuller |
|
These look pretty good, but could you maybe increase the size to a size that is larger than usual so that it's easier to press play, and easier to see the details of the icons? |
For sure, I only kept them small, in case, we need to convert them to small gifs. For press play, I would increase the size. |
|
@gspencergoog Screen.Recording.2022-10-14.at.11.14.35.mov |
| )..addListener(() { | ||
| setState(() { | ||
| // The animation controller is changing the animation value, so we | ||
| // need to redraw. | ||
| }); | ||
| }); |
There was a problem hiding this comment.
AnimatedBuilder is a cleaner way of rebuilding subtrees when a Listenable updates
TahaTesser
force-pushed
the
animated_icons_diagrams
branch
from
642ebbd to
6538e3b
Compare
3 participants
This PR generates all the
AnimatedIconsfor flutter/flutter#113075.The issue requests images or better, gifs,
diagram_generatoronly support generatingmp4files for animations.I could manually run
ffmpegcommand to convert these.mp4s to.gifsand update this PR.Like this,
ffmpeg -i add_event.mp4 add_event.gifor
I'm somewhat familiar with
ffmpeg, I could add support for generatinggifs inbin/generate.dartin a separate PR.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.