This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Revert "Add compiler flags suggested by security review (#4368) (#177)"#186
Merged
goderbauer merged 1 commit intoflutter:masterfrom Oct 29, 2018
Merged
Revert "Add compiler flags suggested by security review (#4368) (#177)"#186goderbauer merged 1 commit intoflutter:masterfrom
goderbauer merged 1 commit intoflutter:masterfrom
Conversation
chinmaygarde
approved these changes
Oct 29, 2018
Contributor
|
(late, but LGTM.) Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9bbd435.
This caused major regressions, see flutter/flutter#23678.
In the future, we can check the flags individually to see which we can add without regressing our benchmarks.