This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Add bitcode argument for compiling with bitcode on iOS#272
Merged
dnfield merged 2 commits intoflutter:masterfrom Jul 13, 2019
Merged
Add bitcode argument for compiling with bitcode on iOS#272dnfield merged 2 commits intoflutter:masterfrom
dnfield merged 2 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
Actually, this seems to just work without adding those symbols... Still verifying. |
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM. Though I don't think patching the host toolchain is necessary.
| ar = "$prefix/llvm-ar" | ||
| cc = "$prefix/clang" | ||
| cxx = "$prefix/clang++" | ||
| if (!enable_bitcode) { |
Contributor
There was a problem hiding this comment.
We can avoid this for host builds. x64
Contributor
Author
There was a problem hiding this comment.
I get linking errors if I don't do this because of gen_snapshot
| ar = "$prefix/llvm-ar" | ||
| cc = "$prefix/clang" | ||
| cxx = "$prefix/clang++" | ||
| if (!enable_bitcode) { |
Contributor
There was a problem hiding this comment.
We can avoid this for host builds. i386
chinmaygarde
approved these changes
Jul 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make this really work, we'll need to land other changes to .S files to include the __LLVM.__asm sections.
Related to flutter/flutter#15288