This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Merged
Conversation
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help with flutter/flutter#37952 and flutter/flutter#39257
For debug builds, we should just use
-fembed-bitcode-markerto speed things up. This is how Apple does it anyway in Xcode. I incorrectly believed thatis_debugwould control this, but that's only forunoptbuilds.This will help with the linked issues because, for some reason (and on CI only), bitcode enabled builds of ios_debug_arm are failing when using bitcode. As much as I'd love to figure out why (it doesn't reproduce locally), we really don't need bitcode there anyway.
I'll have a companion PR to this in the engine that rolls it and adds some changes to the gn script.