Use a sysroot for Linux host builds by default#359
Use a sysroot for Linux host builds by default#359stuartmorgan-g merged 1 commit intoflutter:masterfrom
Conversation
If no explicit sysroot is set, and it's not disabled, use a sysroot for Linux host builds. This means we will no longer require specific libraries to be on CI images for host builds, and developers won't need as much local setup. Fixes flutter/flutter#53176
|
Do the conditions on this look right? The goal is for it to apply only to the Linux host build, not variants (e.g., Fuchsia) or non-host builds (e.g., Android). I can't test this against the engine CI without landing it here first AFAICT, unfortunately, due to the split buildroot/engine repo situation. |
|
Actually, I should be able to do a canary PR against this branch, so I'll do that before landing here. |
|
/cc @iskakaushik because I can never remember the exact is_fuchsia vs is_fuchsia_host and which one is set when :) |
|
Well, Test PR passed compilation, so I'll go ahead and land this. |
If no explicit sysroot is set, and it's not disabled, use a sysroot for Linux host builds. This means we will no longer require specific libraries to be on CI images for host builds, and developers won't need as much local setup. Fixes flutter/flutter#53176
2 participants
If no explicit sysroot is set, and it's not disabled, use a sysroot for
Linux host builds. This means we will no longer require specific
libraries to be on CI images for host builds, and developers won't need
as much local setup.
Fixes flutter/flutter#53176