This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Build libtess2 with less strict warning flags to fix build#545
Merged
zanderso merged 1 commit intoflutter:masterfrom Feb 3, 2022
Merged
Build libtess2 with less strict warning flags to fix build#545zanderso merged 1 commit intoflutter:masterfrom
zanderso merged 1 commit intoflutter:masterfrom
Conversation
chinmaygarde
approved these changes
Feb 3, 2022
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Didn't realize I had this uncommitted. Yes, without this patch, the release builds fail because the variable is only used in an assertion.
Another away to fix this would be to disable the warning in cflags_c. But this way is cleaner.
Member
Author
Huh. There might be a problem with how asserts are enabled, then because I hit the compilation error in a debug build. I will land this and spend a couple minutes looking into it. |
zanderso
added a commit
to flutter/engine
that referenced
this pull request
Feb 3, 2022
To pick up flutter/buildroot#545
Contributor
|
That’s odd. Did you mean debug runtime mode or unopt? C asserts are defined
away in unopt which was making the var go unused.
…On Thu, Feb 3, 2022 at 8:14 AM Zachary Anderson ***@***.***> wrote:
Merged #545 <#545> into master.
—
Reply to this email directly, view it on GitHub
<#545 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKYNMMCF3ZEKMTT6XRTPTUZKSVXANCNFSM5NN62HBA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Member
Author
|
Oh, yeah. I wasn't using --unopt. That was probably it. |
zanderso
added a commit
to flutter/engine
that referenced
this pull request
Feb 3, 2022
To pick up flutter/buildroot#545
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, the
impeller_unitteststarget fails to build, giving the error: