This repository was archived by the owner on Apr 21, 2025. It is now read-only.
[win32] Disable swiftshader iterator warnings#562
Merged
cbracken merged 1 commit intoflutter:masterfrom Apr 13, 2022
cbracken:iterator-deprecation-warnings
Merged
[win32] Disable swiftshader iterator warnings#562cbracken merged 1 commit intoflutter:masterfrom cbracken:iterator-deprecation-warnings
cbracken merged 1 commit intoflutter:masterfrom
cbracken:iterator-deprecation-warnings
Conversation
Suppresses several Windows-specific warnings emitted during swiftshader builds: * On swiftshader builds against Win32 C++ headers, warnings are emitted about subclassing std::iterator, which was deprecated in C++17. This affects a header file in swiftshader's third-party directory: third_party/swiftshader/third_party/llvm-subzero/include/llvm/ADT/iterator.h * Three functions in libVulkan.cpp are re-declared with a difference in dllexport attribute only. * Silence implicit string conversion warnings in two places in swiftshader where asserts of the form assert(!"Error msg") are used. Issue: flutter/flutter#59199
jason-simmons
approved these changes
Apr 13, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppresses several Windows-specific warnings emitted during swiftshader
builds:
On swiftshader builds against Win32 C++ headers, warnings are emitted
about subclassing std::iterator, which was deprecated in C++17. This
affects a header file in swiftshader's third-party directory:
third_party/swiftshader/third_party/llvm-subzero/include/llvm/ADT/iterator.h
Three functions in libVulkan.cpp are re-declared with a difference in
dllexport attribute only.
Silence implicit string conversion warnings in two places in
swiftshader where asserts of the form assert(!"Error msg") are used.
Issue: flutter/flutter#59199
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.