This repository was archived by the owner on Apr 21, 2025. It is now read-only.
[Win32] Don't warn on #pragma optimize#563
Merged
cbracken merged 1 commit intoflutter:masterfrom Apr 15, 2022
cbracken:win-pragma-optimize
Merged
[Win32] Don't warn on #pragma optimize#563cbracken merged 1 commit intoflutter:masterfrom cbracken:win-pragma-optimize
cbracken merged 1 commit intoflutter:masterfrom
cbracken:win-pragma-optimize
Conversation
Disable this warning when building with clang on Windows, which has no support for #pragma optimize. See: https://crbug.com/505314#c13 Issue: flutter/flutter#59199
chinmaygarde
approved these changes
Apr 15, 2022
8 tasks
cbracken
added a commit
to flutter/engine
that referenced
this pull request
Apr 15, 2022
Includes: * 2c4c3a6 [Win32] Don't warn on certain deprecated stdlib fns (flutter/buildroot#564) * 678ecd4 [Win32] Don't warn on #pragma optimize (flutter/buildroot#563) Issue: flutter/flutter#59199
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Apr 20, 2022
Includes: * 2c4c3a6 [Win32] Don't warn on certain deprecated stdlib fns (flutter/buildroot#564) * 678ecd4 [Win32] Don't warn on #pragma optimize (flutter/buildroot#563) Issue: flutter/flutter#59199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable this warning when building with clang on Windows, which has no
support for #pragma optimize. This affects ICU and the Dart VM.
See: https://crbug.com/505314#c13
Issue: flutter/flutter#59199
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.