This repository was archived by the owner on Apr 21, 2025. It is now read-only.
[gn] add forward variables to compiled_action#585
Merged
XilaiZhang merged 2 commits intoflutter:masterfrom Jun 24, 2022
Merged
Conversation
zanderso
reviewed
Jun 24, 2022
build/compiled_action.gni
Outdated
| pool = invoker.pool | ||
| } | ||
|
|
||
| forward_variables_from(invoker, ["metadata"]) |
Member
There was a problem hiding this comment.
You can use forward_variables_from for the three above too as a cleanup:
Suggested change
| forward_variables_from(invoker, ["metadata"]) | |
| forward_variables_from(invoker, ["metadata", "pool", "testonly", "visibility"]) |
Contributor
Author
There was a problem hiding this comment.
Very true! newest commit forwards all suitable variables.
zanderso
approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context: flutter/engine#34216 (comment)
This commit forwards the metadata variable in
generate_snapshot_bin template, which is used to generate thegen_snapshotengine artifact. Together with the PR on flutter/engine side, this PR eventually aims to embed entitlement metadata in the leaf build targets.