Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

[Win] Enable control flow guard compiler option#638

Merged
cbracken merged 1 commit intoflutter:masterfrom
cbracken:cf-guard
Oct 7, 2022
Merged

[Win] Enable control flow guard compiler option#638
cbracken merged 1 commit intoflutter:masterfrom
cbracken:cf-guard

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Oct 7, 2022

Enables the /guard:cf flag in the MSVC compile options. This causes the compiler to analyze control flow for indirect call targets at compile time, and insert checks to verify the targets at runtime. This flag is a requirement for Google apps.

Issue: flutter/flutter#113119

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Enables the /guard:cf flag in the MSVC compile options. This causes the
compiler to analyze control flow for indirect call targets at compile
time, and insert checks to verify the targets at runtime. This flag is a
requirement for Google apps.

Issue: flutter/flutter#113119
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken merged commit c5de0c1 into flutter:master Oct 7, 2022
@cbracken cbracken deleted the cf-guard branch October 7, 2022 19:32
cbracken added a commit to flutter/engine that referenced this pull request Oct 7, 2022
Includes:
* Bump github/codeql-action from 2.1.26 to 2.1.27 (flutter/buildroot#637)
* [Win] Enable control flow guard compiler option (flutter/buildroot#638)

Issue: flutter/flutter#113119
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants