This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Sort macOS SDK paths to keep order stable between runs#652
Merged
jmagman merged 1 commit intoflutter:masterfrom Nov 30, 2022
Merged
Sort macOS SDK paths to keep order stable between runs#652jmagman merged 1 commit intoflutter:masterfrom
jmagman merged 1 commit intoflutter:masterfrom
Conversation
1 task
Contributor
|
auto label is removed for flutter/buildroot, pr: 652, Failed to merge pr#: 652 with Pull request could not be merged: Resource not accessible by integration. |
Member
Author
|
Merging manually. |
jmagman
added a commit
to flutter/engine
that referenced
this pull request
Nov 30, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xcodebuild -showsdks -jsonis returning the samesdkVersionfor differentsdkPaths on > Xcode 14The order it's returning these isn't stable, so it keeps swapping which path is listed last on different runs which is causing
-isysrootto be different between ninja runs, which is unnecessaryly dirtying and causing huge recompiles.Sort the SDKs returned by
xcodebuild -showsdksso that duplicatedsdkVersions mapped to different paths always chooses the same path between runs.Fixes flutter/flutter#112928
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.