This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Be explicit about the iOS SDK version and deployment targets.#67
Closed
chinmaygarde wants to merge 1 commit intoflutter:masterfrom
Closed
Be explicit about the iOS SDK version and deployment targets.#67chinmaygarde wants to merge 1 commit intoflutter:masterfrom
chinmaygarde wants to merge 1 commit intoflutter:masterfrom
Conversation
We used to pick the iOS SDK that was pointed to by the symlink in Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs which could point to a build platform specified version of the SDK. Now, we need to be explicit about the target iOS SDK.
Contributor
Author
|
Depends on the buildbot being ready with iOS SDK 10 flutter/flutter#10510 |
chinmaygarde
commented
Jun 7, 2017
|
|
||
| # Version of the iOS SDK to use (may be higher than the deployment target if | ||
| # the code has been written with appropriate version checks). | ||
| ios_sdk_target = "10.3" |
Contributor
Author
There was a problem hiding this comment.
We should call this ios_sdk_version instead.
Member
|
|
cbracken
approved these changes
Jun 9, 2017
Contributor
Author
|
Damn. I totally forgot about this patch. Will recreate and submit another one. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to pick the iOS SDK that was pointed to by the symlink in Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs which could point to a build platform specified version of the SDK. Now, we need to be explicit about the target iOS SDK.