This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Handle proto deps that were added to the Dart SDK#670
Merged
zanderso merged 1 commit intoflutter:masterfrom Jan 26, 2023
derekxu16:handle-dart-proto-deps
Merged
Handle proto deps that were added to the Dart SDK#670zanderso merged 1 commit intoflutter:masterfrom derekxu16:handle-dart-proto-deps
zanderso merged 1 commit intoflutter:masterfrom
derekxu16:handle-dart-proto-deps
Conversation
Contributor
Author
|
Here is my planned process for integrating these changes:
Plese let me know if this sounds good. |
zanderso
reviewed
Jan 24, 2023
Member
|
@godofredoc I am seeing a new step here to run presubmit checks. Was this turned on intentionally? |
Contributor
This is the github
Nothing has been updated in our side. Waiting for approval to run presubmit checks on PRs created by non members of the Flutter Github Org is the github's default behavior. |
zanderso
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dart SDK will be adding third-party dependencies that it needs to serialize protos in https://dart-review.googlesource.com/c/sdk/+/278200.