This repository was archived by the owner on Apr 21, 2025. It is now read-only.
[dart] Add ntdll.lib for better exception handling in dart#709
Merged
aam merged 1 commit intoflutter:masterfrom Apr 10, 2023
Merged
[dart] Add ntdll.lib for better exception handling in dart#709aam merged 1 commit intoflutter:masterfrom
aam merged 1 commit intoflutter:masterfrom
Conversation
zanderso
suggested changes
Apr 10, 2023
| "dnsapi.lib", | ||
| "iphlpapi.lib", | ||
| "msimg32.lib", | ||
| "ntdll.lib", |
Member
There was a problem hiding this comment.
Shouldn't this go here https://github.com/dart-lang/sdk/blob/main/runtime/BUILD.gn#L148, and should it be limited to only some runtime modes?
Member
There was a problem hiding this comment.
In order to get unblocked, we can go with this, but please file an issue to follow up.
zanderso
approved these changes
Apr 10, 2023
| "dnsapi.lib", | ||
| "iphlpapi.lib", | ||
| "msimg32.lib", | ||
| "ntdll.lib", |
Member
There was a problem hiding this comment.
In order to get unblocked, we can go with this, but please file an issue to follow up.
aam
added a commit
to aam/buildroot
that referenced
this pull request
Apr 11, 2023
…lutter#709)" This reverts commit e18c162 as there is no longer a need for the library to be added into flutter since been added to dart vm BUILD.gn in https://dart.googlesource.com/sdk/+/617925e0c5b24d5b11784056ce1b61a686bd18a5 BUG=flutter/flutter#124532
aam
added a commit
that referenced
this pull request
Apr 11, 2023
) (#711) This reverts commit e18c162 as there is no longer a need for the library to be added into flutter since been added to dart vm BUILD.gn in https://dart.googlesource.com/sdk/+/617925e0c5b24d5b11784056ce1b61a686bd18a5 BUG=flutter/flutter#124532
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API added in https://dart.googlesource.com/sdk/+/386a87a8905c48342e1bb9dcbe0ff693690468a7 for better exception handling on Windows needs this library.