This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Conversation
bdero
force-pushed
the
bdero/malioc-errors
branch
from
0dc1aab to
84f3ac2
Compare
bdero
added a commit
to flutter/engine
that referenced
this pull request
Jun 17, 2023
Resolves flutter/flutter#128989. Also bumps the buildroot to head for: flutter/buildroot#744
zanderso
reviewed
Jun 21, 2023
|
|
||
| import json | ||
| import os | ||
| import sys |
| @@ -0,0 +1,54 @@ | |||
| # Copyright 2013 The Flutter Authors. All rights reserved. | |||
Member
There was a problem hiding this comment.
I'm a bit uncertain about the need for this wrapper script since the script that it wraps is already a wrapper around the underlying malioc binary. Is there some way to merge this functionality into the existing wrapper script in the engine repo?
Contributor
Author
There was a problem hiding this comment.
Oh shoot, I should have read malioc.gni more closely. I mistakenly thought it was running malioc directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#128989.
The Mali Offline compiler outputs errors in the output file. So add a special execution script that dumps the output file to stdout when malioc fails.