This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Rename FIDL tables.c to old_tables.c#795
Merged
tarobins merged 1 commit intoflutter:masterfrom Dec 5, 2023
Merged
Conversation
In fuchsia.git, we are moving FIDL coding table generation from fidlc to fidlgen_hlcpp (https://fxbug.dev/39388). The first step of that is to make fidlgen_hlcpp emit an empty tables.c: https://fxrev.dev/953989. However, flutter is currently placing fidlc's table.c at the same path. Renaming it to old_tables.c unblocks the soft transition.
Contributor
Author
|
@arbreng Tagging you since you merged my other flutter PRs before. |
cligh
approved these changes
Dec 5, 2023
mk12
added a commit
to mk12/buildroot
that referenced
this pull request
Dec 6, 2023
This is a continuation of flutter#795. This tables.c file is currently empty, but we will migrate the fidlc coding tables to it. See https://fxrev.dev/953989 for the full soft transition plan.
mk12
added a commit
to mk12/buildroot
that referenced
this pull request
Dec 7, 2023
This is a continuation of flutter#795. This tables.c file is currently empty, but we will migrate the fidlc coding tables to it. See https://fxrev.dev/953989 for the full soft transition plan.
mk12
added a commit
to mk12/buildroot
that referenced
this pull request
Dec 7, 2023
This is a continuation of flutter#795. This tables.c file is currently empty, but we will migrate the fidlc coding tables to it. See https://fxrev.dev/953989 for the full soft transition plan.
jrwang
pushed a commit
that referenced
this pull request
Dec 7, 2023
This is a continuation of #795. This tables.c file is currently empty, but we will migrate the fidlc coding tables to it. See https://fxrev.dev/953989 for the full soft transition plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In fuchsia.git, we are moving FIDL coding table generation from fidlc to fidlgen_hlcpp (https://fxbug.dev/39388). The first step of that is to make fidlgen_hlcpp emit an empty tables.c: https://fxrev.dev/953989. However, flutter is currently placing fidlc's table.c at the same path. Renaming it to old_tables.c unblocks the soft transition.