This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Fixes to run apple SDK finders as gclient hooks#825
Merged
zanderso merged 1 commit intoflutter:masterfrom Feb 29, 2024
Merged
Conversation
zanderso
force-pushed
the
run-find-sdk-as-hook
branch
3 times, most recently
from
6e00045 to
00a7505
Compare
jmagman
approved these changes
Feb 26, 2024
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
I'm not familiar with this, but the SDK version isn't changing so RSLGTM
zanderso
force-pushed
the
run-find-sdk-as-hook
branch
2 times, most recently
from
c612334 to
b0449c8
Compare
johnmccutchan
approved these changes
Feb 29, 2024
zanderso
force-pushed
the
run-find-sdk-as-hook
branch
from
b0449c8 to
8db99ae
Compare
zanderso
added a commit
to flutter/engine
that referenced
this pull request
Mar 1, 2024
Currently, these scripts run on each invocation of `gn`, and can take many seconds to run. This PR shifts them to run as `gclient` hooks instead, so that `gn` will be faster. Needs flutter/buildroot#825.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports flutter/engine#50957