whitelisted accounts; better sign in/out ergonomics#12
Merged
yjbanov merged 1 commit intoflutter:masterfrom Jul 26, 2016
yjbanov:account-whitelist
Merged
whitelisted accounts; better sign in/out ergonomics#12yjbanov merged 1 commit intoflutter:masterfrom yjbanov:account-whitelist
yjbanov merged 1 commit intoflutter:masterfrom
yjbanov:account-whitelist
Conversation
- Create a table of whitelisted Google accounts that are allowed to access the dashboard (this is for wall-mounted TVs) - Add “Sign in” and “Sign out” buttons instead of automatic redirects for better authentication experience (for example if signed in under a wrong Google account we enter an infinite redirect loop)
|
rslgtm |
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
…ice class (#3026) We are getting alert for 500 errors from the /api/github/webhook-branch-subscription endpoint when attempting to insert a commit for a release branch. The issue is with the timestamp presumably being null when we attempt to insert it into the database since it not a field in the return RepositoryCommit in the github lib. ``` "Failed to process Instance of 'PushMessage'. (500) Invalid argument(s): Error while encoding entity (Bad state: Property validation failed for property timestamp while trying to serialize entity of kind Commit. , #0 _ModelDescription._encodeProperty (package:gcloud/src/db/model_db_impl.dart:449:7) #1 _ModelDescription.encodeModel.<anonymous closure> (package:gcloud/src/db/model_db_impl.dart:429:7) #2 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13) #3 _ModelDescription.encodeModel (package:gcloud/src/db/model_db_impl.dart:428:34) #4 ModelDBImpl.toDatastoreEntity (package:gcloud/src/db/model_db_impl.dart:121:31) #5 _commitHelper (package:gcloud/src/db/db.dart:434:38) #6 Transaction.commit (package:gcloud/src/db/db.dart:118:14) #7 DatastoreService.insert.<anonymous closure>.<anonymous closure> (package:cocoon_service/src/service/datastore.dart:254:31) #8 DatastoreDB.withTransaction.<anonymous closure> (package:gcloud/src/db/db.dart:324:32) #9 _rootRunUnary (dart:async/zone.dart:1407:47) <asynchronous suspension> #10 DatastoreService.insert.<anonymous closure> (package:cocoon_service/src/service/datastore.dart:252:11) <asynchronous suspension> #11 RetryOptions.retry (package:retry/retry.dart:131:16) <asynchronous suspension> #12 DatastoreService.insert (package:cocoon_service/src/service/datastore.dart:250:7) <asynchronous suspension> #13 CommitService.handleCreateGithubRequest (package:cocoon_service/src/service/commit_service.dart:42:7) <asynchronous suspension> #14 GithubBranchWebhookSubscription.post (package:cocoon_service/src/request_handlers/github/branch_subscription.dart:56:7) <asynchronous suspension> #15 RequestHandler.service.<anonymous closure> (package:cocoon_service/src/request_handling/request_handler.dart:53:24) <asynchronous suspension> #16 SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:138:5) <asynchronous suspension> #17 main.<anonymous closure>.<anonymous closure> (file:///app/bin/server.dart:303:11) <asynchronous suspension> ``` The data returned by the call in the Commit Service looks like this: ``` { "sha": "6fd42536b7697eb4bd2a698b19308e0aacac70c7", "node_id": "C_kwDOAeUeuNoAKDZmZDQyNTM2Yjc2OTdlYjRiZDJhNjk4YjE5MzA4ZTBhYWNhYzcwYzc", "commit": { "author": { "name": "Xilai Zhang", "email": "[email protected]", "date": "2023-08-30T02:59:02Z" }, "committer": { "name": "GitHub", "email": "[email protected]", "date": "2023-08-30T02:59:02Z" }, "message": "[flutter roll] Revert \"Fix `Chip.shape`'s side is not used when provided in Material 3\" (#133615)\n\nReverts flutter/flutter#132941\r\ncontext: b/298110031\r\n\r\nThe rounded rectangle borders don't appear in some of the internal\r\ngolden image tests.", "tree": { "sha": "e5efe7f39155d9b8fc40ad0a59c72f6a36f8b66d", "url": "https://api.github.com/repos/flutter/flutter/git/trees/e5efe7f39155d9b8fc40ad0a59c72f6a36f8b66d" }, ``` The author field in this case has no createdAt timestamp. *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#133707 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
access the dashboard (this is for wall-mounted TVs)
for better authentication experience (for example if signed in under a
wrong Google account we enter an infinite redirect loop)
/cc @devoncarew @sethladd